Fix repeat sometimes stopping at end of file #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gapless files sometimes have a 999 entry, and sometimes don't. When they don't, playback continues until the end of the file. If a file doesn't have a 999 entry, it's possible for the file to end before a seek happens, and for the seek to happen when we're trying to replay the file insted of seek. This causes an error and causes the playback to stop. This patch works around this by properly seeking if the end of file is reached in a gapless file (instead of trying to re-play).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gapless files sometimes have a 999 entry, and sometimes don't. When they
don't, playback continues until the end of the file. If a file doesn't
have a 999 entry, it's possible for the file to end before a seek
happens, and for the seek to happen when we're trying to replay the file
insted of seek. This causes an error and causes the playback to stop.
This patch works around this by properly seeking if the end of file is
reached in a gapless file (instead of trying to re-play).