Add a fallback url for when main urls don't work #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozbek
reviewed
Dec 28, 2020
| if (urlString.contains("quran.com") || urlString.contains("quranicaudio.com")) { | ||
| url = urlString.replace("https://", "http://"); | ||
| if (fallbackByDefault || i > 0) { | ||
| if (urlString.contains("android.quran.com")) { |
There was a problem hiding this comment.
You could directly use replace without if block/check, because with contains and replace you are doing double look-up anyway.
There was a problem hiding this comment.
jazakAllah khairan - done
ozbek
reviewed
Dec 28, 2020
| compositeDisposable.add( | ||
| imageUtil.downloadImage(url, previewImage) | ||
| .onErrorResumeNext(imageUtil.downloadImage(backupUrl, previewImage)) |
There was a problem hiding this comment.
Elsewhere you are replaceing on error, here a separate variable. Maybe use a common convention?
Actually, I personally would prefer to have a single utility class/method for all replacements :)
There was a problem hiding this comment.
jazakAllah khairan - done
ahmedre
force-pushed
the
download_fallback
branch
from
cff2450
to
77afd09
Compare
ahmedre
force-pushed
the
download_fallback
branch
from
77afd09
to
ef8005a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.