Use NumberPicker for Range and Verse Repeat Selection

[benomaire]

This is a replacement of #1220 Thanks to @fnzainal for starting this.
Should fix #985
Now we have 99 options for repeating. And yes, we lost the suffix 'time' or 'times'.
For Arabic, I used a string array to flip the visual appearance of the horizontal number picker.

[ahmedre]

haven't tested this yet, but some initial comments

[ahmedre]

instead of this, can we just do:

val numberFormatter = NumberFormat.getInstance(Locale.ARABIC);
numberFormatter.format(number)

instead of having this array of numbers? as a matter of fact, guessing if we don't pass the locale, it gets it from the default locale, which we should be overriding to Arabic already.

[ahmedre]

probably don't need a version check here since these are just numbers - only restricting the tafseer text because the tashkeel renders strange on older versions, numbers should be ok though

[ahmedre]

what do you think about using he default Android NumberPicker? the only downside is we can't style it on api levels before 24, but i think that is ok?

[ahmedre]

also jazakumAllah khairan for pushing this forward!

[benomaire]

Replying to all your very resonable comments:

1. I want a horizontal number picker, hopefully looking the same on all devices. This answer looks discouraging for the default NumberPicker. The used NumberPicker is easily customizable and works on API 15.
2. I agree the string array is very ugly. But the main reason is I flip the numbers. So the NumberPicker looks to be from right to left (for Arabic users). I actually did not notice setOrder, and that is mainly why I did that ugly solution.

So the only thing remaining is whether we keep the external NumberPicker.

[ahmedre]

جزاكم الله خيراً
really sorry for the very late review - just tried this and it looks good, barak Allah feekum - one minor thing - may we make the font size smaller in English? please see:

also - maybe let's make the max 25? 99 seems a bit excessive?
جزاكم الله خيراً

[ahmedre]

i made a small change here - combined all these layouts into 2 layouts - one for play_each_verse and one for play_set_of_verses so we can change one instead of changing all of them

[ahmedre]

merged at b8ebffe and some other commits.
please do see if you can fix the font size in English though - maybe a dimen for the text size that's different for Arabic and English - jazakumAllah khairan

[benomaire]

also - maybe let's make the max 25? 99 seems a bit excessive?

But you had the infinite loop before :)