Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PageContentType to a sealed class #2301

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Jun 14, 2023

This allows passing more details to types that need it.

This allows passing more details to types that need it.
@github-actions
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │  12.2 MiB │  12.2 MiB │ +686 B │  31.1 MiB │  31.1 MiB │ +1.5 KiB 
     arsc │   2.1 MiB │   2.1 MiB │    0 B │   2.1 MiB │   2.1 MiB │      0 B 
 manifest │   5.5 KiB │   5.5 KiB │    0 B │  26.5 KiB │  26.5 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │    0 B │   1.8 MiB │   1.8 MiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │    0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 180.5 KiB │ 180.5 KiB │   +3 B │ 368.8 KiB │ 368.8 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  16.5 MiB │  16.5 MiB │ +689 B │    36 MiB │    36 MiB │ +1.5 KiB 


@ahmedre ahmedre merged commit 08a0160 into master Jun 14, 2023
@ahmedre ahmedre deleted the page_content_type_sealed branch June 14, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant