Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: remove advanced options category, move volume key navigation #731

Merged
merged 2 commits into from
Dec 11, 2016
Merged

Settings: remove advanced options category, move volume key navigation #731

merged 2 commits into from
Dec 11, 2016

Conversation

ozbek
Copy link
Contributor

@ozbek ozbek commented Dec 11, 2016

Fixes #704.

As we are using a separate screen and have "Advanced options" in the title, the category seems redundant
@ozbek
Copy link
Contributor Author

ozbek commented Dec 11, 2016

Dec 11, 2016 1:29:57 PM okhttp3.mockwebserver.MockWebServer$4 processOneRequest
INFO: MockWebServer[34394] received request: GET /data/translations.php?v=3 HTTP/1.1 and 
responded: HTTP/1.1 500 Server Error
Dec 11, 2016 1:29:57 PM okhttp3.mockwebserver.MockWebServer$3 acceptConnections
INFO: MockWebServer[34394] done accepting connections: Socket closed

:'(

@ahmedre
Copy link
Contributor

ahmedre commented Dec 11, 2016

the 500 is actually not the problem (if you're curious, i test what happens if the server throws a 500 error during the unit test, which is why that message is there).

the actual errors are my fault from the tag test - i'll look at them insha'Allah.

@ahmedre ahmedre merged commit 1cf56b7 into quran:master Dec 11, 2016
@ozbek ozbek deleted the settings branch December 11, 2016 23:37
ahmedre pushed a commit that referenced this pull request Oct 14, 2017
#731)

* Remove "Advanced options" category

As we are using a separate screen and have "Advanced options" in the title, the category seems redundant. Also move volume key navigation to reading prefs category.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants