state2state_rl implementation #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le based on how many controls there are. using mesolve with QobjEvo object _H
_infidelity() more general
src/qutip_qoc/_rl.py
Outdated
| # Define action and observation spaces (Gym) | ||
| #self.action_space = spaces.Box(low=-1, high=1, shape=(1,), dtype=np.float32) # Continuous action space from -1 to +1, as suggested from gym | ||
| self.action_space = spaces.Box(low=-1, high=1, shape=(len(self._Hc_lst[0]),), dtype=np.float32) | ||
| self.observation_space = spaces.Box(low=-1, high=1, shape=(4,), dtype=np.float32) # Observation space, |v> have 2 real and 2 imaginary numbers -> 4 |
There was a problem hiding this comment.
Suggested change
| self.observation_space = spaces.Box(low=-1, high=1, shape=(4,), dtype=np.float32) # Observation space, |v> have 2 real and 2 imaginary numbers -> 4 | |
| self.observation_space = spaces.Box(low=-1, high=1, shape=(dim_m, dim_n, 2), dtype=np.float32) # Observation space for complex matrix or state vector |
… train early, removed update_solver(), use of var_time = True supported, other minor fixes
… added underscore for internal variables, args is now passed as a parameter to _infid(), changes in callback function
|
@LegionAtol can we close this PR? |
…m continues to search for solutions with shorter pulses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.