feat: compatible with chinese like input method #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit fixes following issues: 1. use `-`, `=`, `arrow key` to select candidate. which shouldn't be handle by vim 2. use `left`, `right` to move in marked text by word. which shouldn't be handle by vim directly 3. though inserting marked text directly into UGrid cells, bypass vim key mapping system, only the finall insertText be inserted into vim. so vim map like jk to esc won't affect input method. and when input i in normal mode when input method, I can press <CR> to confirm it and only i will send to vim. this is also the behaviour of mac terminal.
|
Thanks! Since I don't know how to use Chinese input, if Korean input still works, I'll merge it. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes following issues when I use vim with input method:
-,=,arrow keyto select candidate. which shouldn't behandle by vim
left,rightto move in marked text by word. which shouldn'tbe handle by vim directly
key mapping system, only the finall insertText be inserted into vim.
so vim map like jk to esc won't affect input method.
and when input
iin normal mode with input method, I can pressto confirm it and only
iwill send to vim.this PR should fixes #473 #592 #582 and may fixes #766 #771 #858
test against docs/notes-on-cocoa-text-input.md