-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect join in qwat_od.vw_export_meter view #288
Comments
good catch @kandre. Ping us if you need us to propose a pull request |
@haubourg I guess in this case a delta should be written ? |
@kandre yep, a PR for the core model associated with a delta file to migrate the existing databases. |
In QWAT, there's no need to create deltas on views. Just fix the reference in the right export view generation file. See #293 for Fix. This has just to be added to the bugfixes for next release. |
Ok, good to know, thanks. |
I think that the view qwat_od.vw_export_meter view has an incorrect join between qwat_od.district and qwat_od.vw_element_meter:
LEFT JOIN qwat_od.district district ON vw_element_meter.fk_pressurezone = district.id
In my opinion it should be changed to:
LEFT JOIN qwat_od.district district ON vw_element_meter.fk_district = district.id
Accordingly export_meter.py should probably be adapted from:
qwat-data-model/ordinary_data/views/export/export_meter.py
Line 26 in b1126d3
to:
fkey: fk_district
The text was updated successfully, but these errors were encountered: