Fix modmail alias command when no aliases defined #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajax146
requested review from
a team,
Cpt-Dingus and
Lunaberries
and removed request for
a team
ajax146
requested changes
May 2, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where the modmail alias command fails when no aliases are defined by replacing the basic embed with a denial embed and ensuring a proper response is sent.
- Replaces auxiliary.generate_basic_embed with auxiliary.prepare_deny_embed for the “no aliases” case
- Adds an explicit send and return to prevent further command processing
Comments suppressed due to low confidence (1)
techsupport_bot/commands/modmail.py:1378
- The change replaces generate_basic_embed with prepare_deny_embed to handle the no-aliases case properly. Please ensure that prepare_deny_embed is implemented consistently with similar command failure responses elsewhere in the code.
embed = auxiliary.prepare_deny_embed(message="There are no aliases registered for this guild",)
ajax146
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix modmail alias command when no aliases defined
Fixes #1285
In hindsight I should have just put this with my other modmail PR