Skip to content

Mark r_vector::const_iterator::operator* as const #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2020
Merged

Mark r_vector::const_iterator::operator* as const #114

merged 3 commits into from
Oct 9, 2020

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Oct 9, 2020

Fixes #113

@xhochy
Copy link
Contributor Author

xhochy commented Oct 9, 2020

Nicely, these were all fixes that were needed to get Arrow R building on Windows using clang.

@xhochy xhochy force-pushed the const-operator-star branch from 32d1ba0 to 24b6922 Compare October 9, 2020 12:34
@xhochy
Copy link
Contributor Author

xhochy commented Oct 9, 2020

cc @bkietz Any ideas how to fix this properly?

@jimhester jimhester merged commit 5b17608 into r-lib:master Oct 9, 2020
@jimhester
Copy link
Member

Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

r_vector::const_iterator::operator* is not const
2 participants
@xhochy @jimhester