adding empty to vector classes #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimhester
reviewed
Jun 23, 2021
NEWS.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| # cpp11 (development version) | |||
|
|
|||
| *Added `named()` and `empty()` methods to r_vector classes, returning true if named/empty (@sbearrows, #182, #186) | |||
There was a problem hiding this comment.
We should try to follow https://style.tidyverse.org/news.html#common-patterns when formatting news. Maybe these would be better as two separate entries?
- New
x.named()method to check if a vector is named (@sbearrrows, Addnamedmethod forr_vectorclass #186) - New
x.empty()method to check if a vector is empty (@sbearrows, Addemptymethod forr_vectorclasses. #182)
What do you think?
There was a problem hiding this comment.
Sure! Looks good, and thanks for the links
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added news updates for both
named()andempty()to this PRfixes #182