simplify three false conditions for r_vector string (fix #431) - replaces PR #433 #478
+1,311
−1,450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pachadotdev
force-pushed
the
3Fto1T-clean
branch
2 times, most recently
from
df04014 to
00833c0
Compare
pachadotdev
force-pushed
the
3Fto1T-clean
branch
from
00833c0 to
fe2bf32
Compare
pachadotdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #431: simplify the condition that excludes containers constructible from SEXP or strings when converting to C++ containers. This PR contains one commit and only updates inst/include/cpp11/r_vector.hpp.
replaces #433