Skip to content

handle enum with underlying type char #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2020
Merged

handle enum with underlying type char #74

merged 2 commits into from
Aug 6, 2020

Conversation

romainfrancois
Copy link
Collaborator

Follow up to #65

Some enum classes in arrow have char as their underlying type and this avoids as_cpp<char>() which apparently doesn't compile.

closes #73

romainfrancois added a commit to romainfrancois/arrow that referenced this pull request Aug 5, 2020
@romainfrancois
cpp11 handles enums, but this needs r-lib/cpp11#74
f73d255
bkietz
bkietz reviewed Aug 5, 2020
View reviewed changes
romainfrancois added a commit to romainfrancois/arrow that referenced this pull request Aug 6, 2020
@romainfrancois
cpp11 handles enums, but this needs r-lib/cpp11#74
f367a59
romainfrancois and others added 2 commits August 6, 2020 16:01
@romainfrancois
handle enum with underlying type char
dbcc8c5
@romainfrancois @bkietz
Update inst/include/cpp11/as.hpp
a451f4b 
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
@jimhester jimhester merged commit 6815d4b into r-lib:master Aug 6, 2020
@jimhester
Copy link
Member

Thanks!

@romainfrancois romainfrancois deleted the enum_char branch August 6, 2020 16:06
romainfrancois added a commit to romainfrancois/arrow that referenced this pull request Aug 6, 2020
@romainfrancois
PR r-lib/cpp11#74 was merged
08f6290
romainfrancois added a commit to romainfrancois/arrow that referenced this pull request Aug 17, 2020
@romainfrancois
cpp11 handles enums, but this needs r-lib/cpp11#74
57f3014
romainfrancois added a commit to romainfrancois/arrow that referenced this pull request Aug 17, 2020
@romainfrancois
PR r-lib/cpp11#74 was merged
bca4f3b
romainfrancois added a commit to romainfrancois/arrow that referenced this pull request Aug 18, 2020
@romainfrancois
cpp11 handles enums, but this needs r-lib/cpp11#74
c1a4eef
romainfrancois added a commit to romainfrancois/arrow that referenced this pull request Aug 18, 2020
@romainfrancois
PR r-lib/cpp11#74 was merged
0d32b97
romainfrancois added a commit to romainfrancois/arrow that referenced this pull request Aug 20, 2020
@romainfrancois
cpp11 handles enums, but this needs r-lib/cpp11#74
c08468c
romainfrancois added a commit to romainfrancois/arrow that referenced this pull request Aug 20, 2020
@romainfrancois
PR r-lib/cpp11#74 was merged
b4c8060
nealrichardson pushed a commit to romainfrancois/arrow that referenced this pull request Aug 24, 2020
@romainfrancois @nealrichardson
cpp11 handles enums, but this needs r-lib/cpp11#74
f36ff3d
nealrichardson pushed a commit to romainfrancois/arrow that referenced this pull request Aug 24, 2020
@romainfrancois @nealrichardson
PR r-lib/cpp11#74 was merged
0ab7091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkietz bkietz bkietz left review comments

+1 more reviewer

@jimhester jimhester jimhester left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enum with underlying type: char
3 participants
@romainfrancois @jimhester @bkietz