New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: --as-cran to include title case test #1702

Closed
msberends opened this Issue Jan 26, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@msberends

msberends commented Jan 26, 2018

From my submission of today, which had 0 errors, 0 warnings and 0 notes in RStudio when checking with devtools:

Thanks, we see:


The Title field should be in title case, current version then in title case:
'Shiny App for Line By Line Comparison of Two Files'
'Shiny App for Line by Line Comparison of Two Files'

Please fix and resubmit.

Best,
Uwe Ligges

So I made a small mistake; title case not applied. Would it be possible to include this in the Check Package function when the --as-cran parameter is used? Thanks!

@jimhester

This comment has been minimized.

Member

jimhester commented Jan 26, 2018

This check is not run by default with devtools::check() because the check require network access to CRANs servers and take a long time to run.

Using devtools::check(check_version = TRUE) turns on this check, and this check is turned on when using devtools::release(). It will also be turned on if you submit your package to win builder with devtools::build_win() or rhub with rhub::check_for_cran().

These are all checks that are useful to run prior to CRAN submission.

@msberends

This comment has been minimized.

msberends commented Jan 26, 2018

Ah thanks 👍

@msberends msberends closed this Jan 26, 2018

jimhester added a commit to jimhester/devtools that referenced this issue Jan 26, 2018

Set _R_CHECK_CRAN_INCOMING_REMOTE_ if it is available
This turns off only the remote checks vs _R_CHECK_CRAN_INCOMING_ which
turns off all of the incoming checks. So you will still catch spelling /
capitalization issues.

Fixes r-lib#1702
@jimhester

This comment has been minimized.

Member

jimhester commented Jan 26, 2018

I made a change in the devel version of devtools which will now turn on more of the incoming checks, so this specific case will now be caught by devtools::check() with the default arguments and R versions > 3.4.0

@lock

This comment has been minimized.

lock bot commented Sep 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.