Skip to content

Don't ignore any pixel differences. Closes #9 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Don't ignore any pixel differences. Closes #9 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# diffviewer (development version)

* The diffviewer widget previously ignored some very minor pixel differences, but now it will show every difference in red. (#9, #11)

# diffviewer 0.1.0

* Added a `NEWS.md` file to track changes to the package.
4 changes: 4 additions & 0 deletions inst/htmlwidgets/lib/diffviewer/diffviewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,11 @@ diffviewer = (function() {
transparency: 0.2
});

// By default, resemble.js ignores some very small differences between
// images. (https://github.com/r-lib/diffviewer/issues/9). Calling
// ignoreNothing() tells it to show every difference.
resemble(old_img).compareTo(new_img)
.ignoreNothing()
.onComplete(function(data) {
if (!dims()) {
// Store the dimensions if needed.
Expand Down