Allow lower-case method

NEWS.md

@@ -1,6 +1,8 @@
 
 # gh (development version)
 
+* gh now accepts lower-case methods i.e. both `gh::gh("get /users/hadley/repos")` and `gh::gh("GET /users/hadley/repos")` work (@maelle, #167).
+
 * Response headers (`"response_headers"`) and response content
   (`"response_content")` are now returned in error conditions so that error
   handlers can use information, such as the rate limit reset header, when

R/gh_request.R

@@ -44,9 +44,11 @@ gh_set_verb <- function(x) {
     return(x)
   }
 
-  x$method <- gsub("^([^/ ]+)\\s+.*$", "\\1", x$endpoint)
-  stopifnot(x$method %in% c("GET", "POST", "PATCH", "PUT", "DELETE"))
-  x$endpoint <- gsub("^[A-Z]+ ", "", x$endpoint)
+  # Method can be lower-case (e.g. copy-pasting from API docs in Firefox)
+  method <- gsub("^([^/ ]+)\\s+.*$", "\\1", x$endpoint)
+  x$endpoint <- gsub(sprintf("^%s+ ", method), "", x$endpoint)
+  # Now switch method to upper-case
+  x$method <- toupper(method)
   x
 }
 

tests/testthat/_snaps/gh_request.md

@@ -0,0 +1,4 @@
+# gh_make_request() errors if unknown verb
+
+    Unknown HTTP verb: "GEEET"
+

tests/testthat/test-gh_request.R

@@ -115,3 +115,7 @@ test_that("gh_set_url() ensures URL is in 'API form'", {
   out <- gh_set_url(input)
   expect_equal(out$api_url, "https://github.acme.com/api/v3")
 })
+
+test_that("gh_make_request() errors if unknown verb", {
+  expect_snapshot_error(gh("geeet /users/hadley/repos", .limit = 2))
+})

tests/testthat/test-mock-repos.R

@@ -64,7 +64,7 @@ test_that("repos, some basics", {
   expect_false(res$has_wiki)
 
   res <- gh(
-    TMPL("PATCH /repos/{owner}/{repo}"),
+    TMPL("patch /repos/{owner}/{repo}"),
     owner = "gh-testing",
     repo = test_repo,
     name = test_repo,