New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New oauth cache files are not added to .gitignore, .Rbuildignore #436

Closed
jennybc opened this Issue Apr 27, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@jennybc
Member

jennybc commented Apr 27, 2017

If cache = TRUE or cache = "some/path" (vs NA) in httr::oauth2.0_token(), a newly created .httr-oauth file is NOT in fact added to .gitignore and .Rbuildignore. This is contrary to the documentation and, I think?, behaviour at some point in the past. Update: I now think httr has always been this way.

The failure to .gitignore is the bigger problem and has lead to some googlesheets users committing and pushing tokens to GitHub (googlesheets sets cache = TRUE by default).

jennybc added a commit to jennybc/httr that referenced this issue Apr 27, 2017

jennybc added a commit to jennybc/httr that referenced this issue Apr 27, 2017

@hadley hadley closed this in #437 Apr 28, 2017

hadley added a commit that referenced this issue Apr 28, 2017

Expand git and Rbuild ignoring of newly created oauth cache files; fixes
 #436 (#437)

* Fresh starts for oauth caching tests

* Test that new caches are ignored (failing)

* Ignore any newly created cache; fixes #436

* Streamline option setting/restoring in test

* Add NEWS bullet

jiwalker-usgs added a commit to jiwalker-usgs/httr that referenced this issue Jul 24, 2017

Expand git and Rbuild ignoring of newly created oauth cache files; fixes
 r-lib#436 (r-lib#437)

* Fresh starts for oauth caching tests

* Test that new caches are ignored (failing)

* Ignore any newly created cache; fixes r-lib#436

* Streamline option setting/restoring in test

* Add NEWS bullet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment