Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give More Specific OAuth2.0 Error Message if Token Cannot be Refreshed #516

Closed
StevenMMortimer opened this issue Mar 30, 2018 · 0 comments
Closed

Give More Specific OAuth2.0 Error Message if Token Cannot be Refreshed #516

StevenMMortimer opened this issue Mar 30, 2018 · 0 comments
Labels
feature a feature request or enhancement oauth 🏓 wip work in progress

Comments

@StevenMMortimer
Copy link

Currently, when tokens cannot be refreshed a generic warning message is printed "Unable to refresh token"

httr/R/oauth-refresh.R

Line 31 in 1fc6598

warning("Unable to refresh token", call. = FALSE)

A number of more specific error messages are being trapped by known_oauth2.0_error() here

httr/R/oauth-error.r

Line 6 in 1fc6598

oauth2.0_errors <- c(

Is it possible to print out any of the trapped error messages so that we can get some more detail on how to debug if a token cannot be refreshed.
@hadley hadley added feature a feature request or enhancement oauth 🏓 labels Nov 21, 2018
hadley added a commit that referenced this issue Nov 23, 2018
@hadley
Show more details when token refresh fails
9d893c5 
Fixes #516
@hadley hadley added the wip work in progress label Nov 23, 2018
@hadley hadley closed this as completed in a28b4e7 Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement oauth 🏓 wip work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @StevenMMortimer