Test and talk about why id
is awesome
#197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
id
argument in combination with themsg %<~%
delayed assign operator used internally is awesome. It lets us totally avoidlifecycle_message()
indeprecate_soft()
anddeprecate_warn()
, which are expensive.This PR documents this usage of
id
, and adds a test so we hopefully don't regress on this in the future. I also added a comment in 26fa727 about this.When a once per session message has already been thrown and
id
is supplied, we are getting very close to "just early exiting" - almost all of the time is now insignalCondition()
due to it not being as lazy as we'd hope.