Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ## in commented_code_linter? #299

Closed
prosoitos opened this issue Mar 7, 2018 · 2 comments
Closed

Allow ## in commented_code_linter? #299

prosoitos opened this issue Mar 7, 2018 · 2 comments
Labels
bug an unexpected problem or unintended behavior feature a feature request or enhancement

Comments

@prosoitos
Copy link
Contributor

In emacs ESS, ## starts a commented line, while # starts a comment at the end of a code line. This is convenient for auto-indentation (## comments do not indent, while # comments automatically indent).

Lintr considers ## to start a comment as a mistake. Would it create other issues down the line to add ## to the commented_code_linter?
@jimhester
Copy link
Member

I am fine with changing this, would be happy to accept a PR for it!

@jimhester jimhester added enhancement bug an unexpected problem or unintended behavior labels Mar 9, 2018
@prosoitos
Copy link
Contributor Author

Great!

I just gave it a try. This is my very first PR, so please bear with me if I messed something up...

@jimhester jimhester added feature a feature request or enhancement and removed enhancement labels May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimhester @prosoitos