Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?ignored packages is not ignored #423

Closed
billdenney opened this issue Oct 2, 2022 · 10 comments
Closed

?ignored packages is not ignored #423

billdenney opened this issue Oct 2, 2022 · 10 comments

Comments

@billdenney
Copy link

Related to #421, I'm trying to ignore the package lixoftConnectors when installing dependencies.

When I used lixoftConnectors?ignore in the extra-packages list, I got the following error indicating that it was not ignored:

https://github.com/nlmixr2/babelmixr2/actions/runs/3169455077/jobs/5161378366#step:5:109

The instructions I used were:

https://github.com/nlmixr2/babelmixr2/blob/5bd330353cf4ad0b62d0223b656246672119e3b1/.github/workflows/R-CMD-check.yaml#L45-L55

I was trying to follow the instructions here: https://github.com/r-lib/actions/tree/v2-branch/setup-r-dependencies#ignoring-optional-dependencies

@gaborcsardi
Copy link
Member

The syntax is slightly different:

pak::lockfile_create(c("deps::.", "lixoftConnectors=?ignore"), dependencies = TRUE)
✔ Created lockfile pkg.lock [547ms]

@billdenney
Copy link
Author

First, thank you for being so responsive right now. It's very helpful to working through this issue (or these issues)!

I fixed the ignore syntax, but it appears to want to be able to find the package. I now see the same subscript out of bounds error as in #421.

I'm now trying adding the repository back in with extra-repositories: 'https://monolix.lixoft.com/monolix-api/lixoftconnectors_installation/'. (But my baby is waking up, so I'm now done working on it for several hours at least 😄 .)

@billdenney
Copy link
Author

The installation is still not succeeding. I think that I've covered all the main steps as I see them documented:

Can you please help identify what the remaining issue is?

@gaborcsardi
Copy link
Member

Can you link to the failing build?

@billdenney
Copy link
Author

billdenney commented Oct 3, 2022

Here is the GitHub action log: https://github.com/nlmixr2/babelmixr2/actions/runs/3169571113

And, here is the commit that ran it: https://github.com/nlmixr2/babelmixr2/tree/930968565d70a20e7f4c715baf86e9ed2ded7dd3

If you were looking for something else, please let me know.

@gaborcsardi
Copy link
Member

This was a bug in pkgdepends, unfortunately. I'll build new pak binaries and then GHA should be fine.

gaborcsardi added a commit that referenced this issue Oct 3, 2022
@gaborcsardi
Copy link
Member

Try it again please, hopefully it works now.

@billdenney
Copy link
Author

@gaborcsardi , I ran this again about 2 hours ago (without modification), and I was still getting the same issue. Should it have succeeded or is there a delay for changes to propogate?

https://github.com/nlmixr2/babelmixr2/actions/runs/3169571113/jobs/5172821660 (note that the running time is 1 hour ago)

@gaborcsardi
Copy link
Member

It was deployed less than an hour ago.

@billdenney
Copy link
Author

Success! Thank you!

(Well, I still have some work to do as there are testing errors, but the CI seems to be working correctly. 😄 )

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Feb 19, 2023
# pak 0.4.0

* pak has much improved and more informative error messages now.
  This work is not yet finished, so if you find an unclear error message,
  please open an issue. Thank you!

* The solver is now more robust for non-canonical input (e.g. `DESCRIPTION`
  files) (r-lib/pak#423).

* Better installation output. Standard output and error are now
  collected together (r-lib/pkgdepends@0669f0f8c).

* The solver is now doing a better job when multiple versions of the
  same package are present in the same repository
  (r-lib/actions#559).

* `pkg_name_check()` now works again, it needed a fix after changes at
  https://crandb.r-pkg.org.

* Explicit package names in local and URL package sources, as in
  `package=local::...` or `package=url::...` are now parsed correctly in
  dependencies.

* pak is now more robust to `Archs` fields missing from the CRAN
  metadata for packages with compiled code
  (r-lib/pak#448).

* `url::` packages now always work correctly, even if the digest package is
  not installed (r-lib/pak#433).

* pak is now more robust when installing packages from subdirectories
  of GitHub repositories (r-lib/pak#431,
  @paleolimbot).

* Parameters `?reinstall`, `?source` and `?ignore` now work correctly when
  specified in the `package=?parameter` format (#294).

* The `?ignore` parameter works correctly now.

* Dependency resolution now does not fail if a package is not found.

* pak can now install `url::` remotes from GitHub.

* pak now does not fail when the package of a `.tar.gz` GitHub
  snapshot is in a subdirectory, or in a subdirectory of a subdirectory.

* pak now errors early if it cannot deduce the name of the package
  from a `Remotes` or `Config/Needs/*` entry.

* Solver failures now include details in some cases where previously they
  did not.

* pak can now update packages in Docker containers where the
  old version was installed in the different Docker later
  (r-lib/pak#251)

* Update R version -> Bioconductor version mapping. R 4.2.x now maps to
  Bioconductor 3.16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants