-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to external issue overwritten with link to nonexistent internal issue #2122
Comments
Hmmmm, this is going to be tricky to fix with our current regular expression based approach. Maybe we need to switch to something that uses more xpath. |
One thought I had was, it should be possible to create a regex that matches most tags but not |
Test for the problem: # or existing links
expect_equal(repo_auto_link(pkg, "<a href=''>#123</a>"), "<a href=''>#123</a>") |
Merged
hadley
pushed a commit
that referenced
this issue
Mar 11, 2024
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this issue
Jun 1, 2024
Fixes r-lib#2030 (not creating links at line starts) while not breaking r-lib#2122, for most common use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In pkgdown 2.0.3, the following markdown links to #2092 in NEWS.md.
[#2092](https://github.com/r-lib/pkgdown/issues/2092)
In pkgdown 2.0.4, the same code links to the issue for the repository that generated the pkgdown, which seems to be caused by #2104, as a link is added within the link:
From https://github.com/jabenninghoff/testpkg/blob/9510b647385299efdd99d85125a32f6e11fb784c/docs/news/index.html#L54:
Full reprex at: https://github.com/jabenninghoff/testpkg, see: NEWS.md, DESCRIPTION (URL, BugReports).
The text was updated successfully, but these errors were encountered: