fixes #2030 (not creating links at line starts) while not breaking #2122, for most common use case #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Thanks! To finish it off, can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).
Done - fast-forwarded to latest commit on main, then added a bullet at the top of NEWS. |
|
Perfect, thanks! |
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
Fixes r-lib#2030 (not creating links at line starts) while not breaking r-lib#2122, for most common use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2030 was fixed by #2104, but then had to be reverted because the solution cause #2122.
This PR fixes the original issue, without introducing the problem in #2122, for the most common case: a
<p>@user ...or<p>#123 issue ....While other breaking edge cases exist (e.g., if someone has already embedded a
<p>@user</p>inside an anchor tag or some such), those strike me as unlikely practically and, if they did become prevalent, indicating more fundamental refactor (e.g. to xpath-style approaches).