more sidebar customization #1488
Conversation
|
Regarding the question in the issue about images, I suppose "text" could contain an |
R/build-home-index.R
Outdated
| return(pkg$meta$home$sidebar) | ||
|
|
||
| sidebar_path <- file.path(pkg$src_path, pkg$meta$home$sidebar$html) |
There was a problem hiding this comment.
If this is a pointer to a path, it should be html_path or similar. I wonder if this should be in addition to the regular sidebar, rather than a replacement?
There was a problem hiding this comment.
I'm not sure.
- If you want a really custom sidebar you'd provide your own HTML as sidebar.html field.
- If you want to add a custom section (H2 title, any HTML below that), you'd use the sidebar.structure and sidebar.components fields.
There was a problem hiding this comment.
Do we have evidence that folks want to replace the whole sidebar?
There was a problem hiding this comment.
no but this PR already provides a way to add custom component to the navbar.
| @@ -74,15 +74,19 @@ read_desc <- function(path = ".") { | |||
|
|
|||
| # Metadata ---------------------------------------------------------------- | |||
|
|
|||
| read_meta <- function(path) { | |||
| path <- path_first_existing( | |||
| pkgdown_config_path <- function(path) { | |||
There was a problem hiding this comment.
not in scope for this PR but with such a function one could easily have a helper file.edit(pkgdown_config_path("."))
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
|
The failures on macOS are due to the installation of textshaping, that has been released on CRAN yesterday. |
|
I had missed the |
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Fix #1443
TODO