Skip to content

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Sep 14, 2022

bench::mark("x" %in% letters, any(letters == "x"))
#> # A tibble: 2 × 6
#>   expression               min   median `itr/sec` mem_alloc `gc/sec`
#>   <bch:expr>          <bch:tm> <bch:tm>     <dbl> <bch:byt>    <dbl>
#> 1 "x" %in% letters       369ns    492ns  1157064.      256B       0 
#> 2 any(letters == "x")    246ns    287ns  2157463.        0B     216.

Created on 2022-09-14 with reprex v2.0.2

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1001 (65329ed) into main (38f0a3b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 65329ed differs from pull request most recent head c7969fd. Consider uploading reports for the commit c7969fd to get more accurate results

@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
- Coverage   90.27%   90.26%   -0.01%     
==========================================
  Files          47       47              
  Lines        2683     2682       -1     
==========================================
- Hits         2422     2421       -1     
  Misses        261      261              
Impacted Files Coverage Δ
R/detect-alignment-utils.R 97.18% <100.00%> (-0.04%) ⬇️
R/indent.R 100.00% <100.00%> (ø)
R/rules-line-breaks.R 100.00% <100.00%> (ø)
R/ui-caching.R 90.24% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 20cda1f is merged into main:

  •   :ballot_box_with_check:cache_applying: 27ms -> 26.9ms [-2.4%, +1.57%]
  •   :ballot_box_with_check:cache_recording: 1.26s -> 1.26s [-1.78%, +1.66%]
  •   :ballot_box_with_check:without_cache: 3.21s -> 3.22s [-0.6%, +0.77%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 65329ed is merged into main:

  •   :ballot_box_with_check:cache_applying: 27.6ms -> 27.4ms [-2.09%, +0.38%]
  •   :ballot_box_with_check:cache_recording: 1.27s -> 1.27s [-0.37%, +0.51%]
  •   :ballot_box_with_check:without_cache: 3.36s -> 3.38s [-0.14%, +0.81%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil IndrajeetPatil merged commit 08da821 into r-lib:main Sep 14, 2022
@IndrajeetPatil IndrajeetPatil deleted the replace_match_with_all branch September 14, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants