Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw informative error for Windows style EOL (mainly for atom users) #400

Merged
merged 4 commits into from Jun 23, 2018

Conversation

Projects
None yet
2 participants
@lorenzwalthert
Copy link
Collaborator

commented Jun 21, 2018

Ask people to use Unix style EOLs. Fixes #396.

@lorenzwalthert lorenzwalthert force-pushed the lorenzwalthert:crlf branch from fa3f302 to e92b1b8 Jun 21, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Jun 21, 2018

Codecov Report

Merging #400 into master will increase coverage by 0.08%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   89.97%   90.06%   +0.08%     
==========================================
  Files          30       30              
  Lines        1437     1459      +22     
==========================================
+ Hits         1293     1314      +21     
- Misses        144      145       +1
Impacted Files Coverage Δ
R/transform-files.R 100% <100%> (ø) ⬆️
R/utils.R 86.95% <100%> (ø) ⬆️
R/parse.R 82.79% <95.83%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b995fa...e92b1b8. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 66346dc into r-lib:master Jun 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@lorenzwalthert lorenzwalthert deleted the lorenzwalthert:crlf branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.