Allow selecting the style used by RStudio addins.

[riccardoporreca]

• Option "styler.addins.style" stores the selected style.
• New addin to set the style.
• Existing addins adapted to use the selected style.

[codecov-io]

Codecov Report

Merging #463 into master will decrease coverage by 1.95%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #463      +/-   ##
=========================================
- Coverage   90.65%   88.7%   -1.96%     
=========================================
  Files          36      36              
  Lines        1627    1664      +37     
=========================================
+ Hits         1475    1476       +1     
- Misses        152     188      +36

Impacted Files	Coverage Δ
R/addins.R	0% <0%> (ø)	⬆️
R/utils.R	71.87% <0%> (+3.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b7ea1b...de626c9. Read the comment docs.

[lorenzwalthert]

I think we don't want another Addin, see also #250.

[lorenzwalthert]

Actually thanks go @jonmcalder we have figured out that you have not registered a new Addin, just moved existing code. I overlooked that. Sorry. Will add in #500 again.

[riccardoporreca]

I thought this was intentional, as discussed when integrating your tweaks in miraisolutions#1 (comment)

[lorenzwalthert]

Well, the confusion arose because people wanted to add other Addins like #476 and #250 and in the diff, it looked as if you added an Addin for package styling. This was not the case, you just moved some code. So that was my mistake.

[riccardoporreca]

I see, no problem!

[lorenzwalthert]

First of all, thanks @riccardoporreca for the PR. I think I need to test it myself and then I will review the PR.

[riccardoporreca]

@lorenzwalthert, sure, I will also be happy to discuss if, despite the reasonable point of not cluttering the addins, the concept and utilities for setting and using a given style guide for the addins could be still useful.

[lorenzwalthert]

Thanks. Just to make it clear, I see that the PR has two parts and I also think the functionality about style selection is something we'd want to support. Apart from the implementation details, one thing I am not sure about is how to deal with global variables and environment variables and default values. I created fallback and integrated it into styler (compare #319), but I am not sure if it's the best solution. I.e. if the default style should be set in a yaml file.

[lorenzwalthert]

I changed my mind and we will defer the questions regarding default values and just go with R options for now. Hope to find time to review soon.

[lorenzwalthert]

thanks @riccardoporreca. There is one minor thing about error messages which I will fix when working on #472. The Add-in has passed my manual test with the oneline style guide too, so it's all fine 😄.

[riccardoporreca]

Great, well spotted with the error message and the concise rlang alternative.

Thanks @lorenzwalthert for the nice collaboration on the PR.

[lorenzwalthert]

@riccardoporreca I just realized that instead of asking for a style, we should maybe ask for transformers, because then, people could also specify arguments thereof, e.g. the scope:

style_text(transformers = tidyerse_style(scope = "spaces", ...)

This is not currently possible because the input for the Addin is a style, i.e.

styler::tidyverse_style

and not transformers, e.g.

styler::tidyverse_style()

[riccardoporreca]

@riccardoporreca I just realized that instead of asking for a style, we should maybe ask for transformers, because then, people could also specify arguments thereof

@lorenzwalthert, I agree.

I am not sure how you would describe the addin with this new approach, "transformers" is somehow a less intuitive term than "style" for the user, so maybe the addin can still be called "Set Style" and described as "Prompt for and set the style transformers used by all STYLER addins", or something more sensible. Similar for the prompt and error messages.