-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexibility with Addin #500
More flexibility with Addin #500
Conversation
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
==========================================
- Coverage 90.26% 89.98% -0.29%
==========================================
Files 39 39
Lines 1675 1677 +2
==========================================
- Hits 1512 1509 -3
- Misses 163 168 +5
Continue to review full report at Codecov.
|
@riccardoporreca are you interested in reviewing this? Note that the R option name was changed from |
@lorenzwalthert , happy to review this if it can wait until next week, I will not be much on-line before then. |
Ok. I just need to submit a new version to CRAN by Mai 10, so maybe I ask @jonmcalder to review? Code review could also be done later, it's more about making sure the changes introduced (Addins + R options) are working and I did not make a capital mistake and the documentation is understandable. Different user scenarios described under tests/manualtest, which I tried on macOs. |
@lorenzwalthert, sure, feel free to ping me if I can still do something after May 5 before the CRAN submission, or at a later stage for a more involved code review. |
…y. Rename option styler.addins.style -> styler.addins_style_transformer. Overhaul documentumentation for Addins, add life cycle.
4b9925e
to
a246b1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @lorenzwalthert!
Co-Authored-By: lorenzwalthert <lorenz.walthert@icloud.com>
Thanks guys. |
scope
cannot be specified with the style argument alone, because it takes a function name likestyler::tidyverse_style
(this holds for the Addins only). When the transformers argument is used, this is possible: