Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexibility with Addin #500

Merged
merged 16 commits into from May 6, 2019

Conversation

@lorenzwalthert
Copy link
Collaborator

commented Apr 28, 2019

  • let the user specify the transformers, not just the style argument for flexibility. I.e. scope cannot be specified with the style argument alone, because it takes a function name like styler::tidyverse_style (this holds for the Addins only). When the transformers argument is used, this is possible:
style_text("1+1", transformers = tidyverse_style(scope = 'line_break')
  • Rename option styler.addins.style -> styler.addins_style_transformer.
  • Overhaul documentation for Addins, add life cycle.
  • Add manual test instructions for Addins.
@codecov-io

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #500 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   90.26%   89.98%   -0.29%     
==========================================
  Files          39       39              
  Lines        1675     1677       +2     
==========================================
- Hits         1512     1509       -3     
- Misses        163      168       +5
Impacted Files Coverage Δ
R/style-guides.R 100% <ø> (ø) ⬆️
R/addins.R 0% <0%> (ø) ⬆️
R/transform-files.R 100% <0%> (ø) ⬆️
R/rules-line-break.R 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37381a3...941506b. Read the comment docs.

@lorenzwalthert lorenzwalthert marked this pull request as ready for review Apr 28, 2019

@lorenzwalthert

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 28, 2019

@riccardoporreca are you interested in reviewing this? Note that the R option name was changed from styler.addins.style to styler.addins_style_transformer.

@riccardoporreca

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@lorenzwalthert , happy to review this if it can wait until next week, I will not be much on-line before then.

@lorenzwalthert

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 29, 2019

Ok. I just need to submit a new version to CRAN by Mai 10, so maybe I ask @jonmcalder to review? Code review could also be done later, it's more about making sure the changes introduced (Addins + R options) are working and I did not make a capital mistake and the documentation is understandable. Different user scenarios described under tests/manualtest, which I tried on macOs.

@riccardoporreca

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@lorenzwalthert, sure, feel free to ping me if I can still do something after May 5 before the CRAN submission, or at a later stage for a more involved code review.

This was referenced Apr 30, 2019

@lorenzwalthert lorenzwalthert force-pushed the lorenzwalthert:addin-select-style branch from 4b9925e to a246b1e May 3, 2019

@jonmcalder
Copy link
Contributor

left a comment

Looks good to me @lorenzwalthert!

R/addins.R Outdated Show resolved Hide resolved
Update R/addins.R
Co-Authored-By: lorenzwalthert <lorenz.walthert@icloud.com>

@lorenzwalthert lorenzwalthert merged commit 1a58cac into r-lib:master May 6, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lorenzwalthert lorenzwalthert deleted the lorenzwalthert:addin-select-style branch May 6, 2019

@lorenzwalthert

This comment has been minimized.

Copy link
Collaborator Author

commented May 6, 2019

Thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.