New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_reporter and get_reporter #102

Closed
krlmlr opened this Issue Nov 10, 2013 · 7 comments

Comments

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Nov 10, 2013

I have noticed that the (hidden) function test_reporter is going to be renamed to get_reporter in the next release. May I suggest the following:

  • Provide an active binding test_reporter that returns get_reporter and issues a deprecation warning
  • Export get_reporter -- useful for writing own reporters (such as in the tikzDevice tests)

krlmlr pushed a commit to daqana/tikzDevice that referenced this issue Nov 10, 2013

@hadley

This comment has been minimized.

Member

hadley commented Dec 4, 2013

The function wasn't exported, so you're own your own.

@hadley hadley closed this Dec 4, 2013

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 4, 2013

get_reporter() is used in the tests for tikzDevice. Would you consider exporting it, or are there reasons not to?

@hadley

This comment has been minimized.

Member

hadley commented Dec 5, 2013

You should just be able to supply the name of any reporter - does that not work?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 10, 2013

I need access to the currently active reporter from within a test.

@hadley

This comment has been minimized.

Member

hadley commented Dec 11, 2013

Why?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Dec 11, 2013

There might be a better way. The current code requires it to call a function in a custom reporter.

@hadley

This comment has been minimized.

Member

hadley commented Dec 11, 2013

Ok, that seems like a reasonable use case. I'll export get_reporter

@hadley hadley reopened this Dec 11, 2013

@hadley hadley closed this in 5975390 Jan 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment