Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto_test_package() stops on failure #1214

Closed
mbojan opened this issue Oct 31, 2020 · 3 comments · Fixed by #1212
Closed

auto_test_package() stops on failure #1214

mbojan opened this issue Oct 31, 2020 · 3 comments · Fixed by #1212

Comments

@mbojan
Copy link
Contributor

mbojan commented Oct 31, 2020 •
edited

auto_test_package() calls test_dir() which uses stop_on_failure = TRUE by default. The function exits in case of errors while it should not but keep monitoring the source tree.
@mbojan
Copy link
Contributor Author

mbojan commented Oct 31, 2020

Would you like a separate PR or append #1212 ?

mbojan added a commit to mbojan/testthat that referenced this issue Oct 31, 2020
@mbojan
auto_test_package() calls test_dir(stop_on_failure=FALSE)
e0f0a81 
References r-lib#1214.
@hadley
Copy link
Member

hadley commented Nov 1, 2020

Just append please.

mbojan added a commit to mbojan/testthat that referenced this issue Nov 1, 2020
@mbojan
auto_test_package() calls test_dir(stop_on_failure=FALSE)
5617430 
References r-lib#1214.
@mbojan
Copy link
Contributor Author

mbojan commented Nov 1, 2020

Appended. This can be closed as soon as #1212 is merged.

@mbojan mbojan mentioned this issue Nov 1, 2020
Merged
hadley pushed a commit that referenced this issue Dec 1, 2020
@mbojan
Typos in auto_test_package() (#1212)
8f5e4b3 
* Typo in auto_test_package(). Fixes #1211.
* auto_test_package() calls test_dir(stop_on_failure=FALSE). Fixes #1214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typo in auto_test_package() mbojan/testthat
2 participants
@hadley @mbojan