Skip to content

Explicit fmt argument with safe default to difference() #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2016
Merged

Explicit fmt argument with safe default to difference() #446

merged 2 commits into from
Apr 18, 2016

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 9, 2016 •
edited
Loading

Fixes #445.

NEWS entry:

- Hardened formatting of difference messages, previously the presence of % characters could affect the output (#446, @krlmlr).

@krlmlr
Copy link
Member Author

krlmlr commented Apr 9, 2016

I have added a GITHUB_PAT to Travis to avoid build errors.

@krlmlr krlmlr force-pushed the feature/445-sanitize-sprintf branch from 3c127e6 to b80c637 Compare April 16, 2016 14:36
@krlmlr krlmlr mentioned this pull request Apr 16, 2016
Merged
@hadley hadley merged commit b80c637 into r-lib:master Apr 18, 2016
@krlmlr krlmlr deleted the feature/445-sanitize-sprintf branch May 7, 2016 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @hadley