Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_test_scripts should only strip trailing [rR] and not any [rR] #492

Closed
brodieG opened this issue Jul 3, 2016 · 0 comments
Closed

find_test_scripts should only strip trailing [rR] and not any [rR] #492

brodieG opened this issue Jul 3, 2016 · 0 comments
Milestone

Comments

@brodieG
Copy link
Contributor

@brodieG brodieG commented Jul 3, 2016

This line:

test_names <- gsub("\\.[rR]", "", test_names)

Should be (I think):

test_names <- sub("\\.[rR]$", "", test_names)

I'll submit a pull request in a few minutes to fix.

brodieG added a commit to brodieG/testthat that referenced this issue Jul 3, 2016
brodieG added a commit to brodieG/testthat that referenced this issue Jul 3, 2016
@krlmlr krlmlr added this to the 1.0.3 milestone Jul 4, 2016
@krlmlr krlmlr added this to the 1.0.3 milestone Jul 4, 2016
@hadley hadley closed this in f24ab61 Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants