Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect_error could handle the error class #530

Closed
gaborcsardi opened this issue Oct 1, 2016 · 4 comments
Closed

expect_error could handle the error class #530

gaborcsardi opened this issue Oct 1, 2016 · 4 comments
Labels
expectation 🙀 feature a feature request or enhancement

Comments

@gaborcsardi
Copy link
Member

I mean, I want to specify that I expect a given error class, instead of specifying the error message. AFAICT this is currently not possible.
@gaborcsardi gaborcsardi mentioned this issue Dec 9, 2016
Merged
@hadley
Copy link
Member

hadley commented Dec 15, 2016

Great idea. I'd be happy to review a PR :)

@hadley hadley added expectation 🙀 feature a feature request or enhancement labels Dec 15, 2016
@hadley
Copy link
Member

hadley commented Dec 15, 2016

And presumably this should also cover warnings and messages. I'll have a go at it.

@hadley
Copy link
Member

hadley commented Dec 15, 2016

Oh messages() and warnings() are bit trickier because there might be more than one. I'll leave those for now.

@hadley hadley closed this as completed in 5fdf26b Dec 15, 2016
@gaborcsardi
Copy link
Member Author

Great! Thanks! This will allow proper error testing once we have proper error objects in R packages. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expectation 🙀 feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @gaborcsardi