Skip to content

Conversation

comicfans
Copy link
Contributor

Jenkins junit plugin requires time has at most 3 digits, or it reports

junit.xml:cvc-pattern-valid: Value '5.44999999999999' is not facet-valid with respect to pattern '(([0-9]{0,3},)*[0-9]{3}|[0-9]{0,3})*(\.[0-9]{0,3})?' for type 'SUREFIRE_TIME'.

@hadley
Copy link
Member

hadley commented Mar 31, 2019

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@comicfans comicfans force-pushed the improve_junit_time_compatibility branch from 92e747d to 664de37 Compare April 1, 2019 01:18
Jenkins junit requires time has at most 3 digits
@comicfans comicfans force-pushed the improve_junit_time_compatibility branch from 664de37 to 95687d9 Compare April 1, 2019 01:23
@comicfans
Copy link
Contributor Author

of course , but I found bullet is written as (#issuenumber, @username) so I followed this style

@hadley hadley merged commit e703dba into r-lib:master Apr 1, 2019
@hadley
Copy link
Member

hadley commented Apr 1, 2019

Thanks, although in the future please follow the new bullet style that I requested, not the old.

@comicfans comicfans deleted the improve_junit_time_compatibility branch April 1, 2019 12:26
@comicfans
Copy link
Contributor Author

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants