Warn when snapshots are discarded #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Dec 11, 2020
NEWS.md
Outdated
| @@ -1,12 +1,16 @@ | |||
| # testthat (development version) | |||
|
|
|||
| * A warning is given when snapshots are discarded due to reusing the same | |||
| test name (#1278, @krlmlr). | |||
|
|
|||
| * New `testthat.progress.verbose_skips` option. Set to `FALSE` to stop | |||
| reporting skips as they occur, they will still appear in the summary | |||
| (#1209, @krlmlr). | |||
|
|
|||
| * `CheckReporter` now always shows the full test name (#1268). | |||
|
|
|||
| * Catch tests are no longer reported multiple times (#1237). | |||
There was a problem hiding this comment.
Do you mind deleting this bullet since it's repeated below and problem comes from a merge?
R/snapshot-reporter.R
Outdated
| @@ -87,7 +90,7 @@ SnapshotReporter <- R6::R6Class("SnapshotReporter", | |||
| self$cur_snaps[[self$test]] <- self$old_snaps[[self$test]] | |||
|
|
|||
| if (self$i > 0) { | |||
| testthat_warn("Snapshots reset after error/skip") | |||
| testthat_warn(paste0("Snapshots reset after error/skip: ", test)) | |||
There was a problem hiding this comment.
Won't the test name have been printed above?
There was a problem hiding this comment.
Probably, let's try and see.
krlmlr
force-pushed
the
f-verbose-discard-message
branch
from
c06b0cd
to
ceb2a4f
Compare
krlmlr
changed the title
|
Do we need to always warn with duplicate tests ( |
hadley
reviewed
Dec 11, 2020
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we need to always warn with duplicate tests (
is.null()vs.length() == 0)?