Skip to content

WIP on expect_all_equal() #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

WIP on expect_all_equal() #2259

wants to merge 8 commits into from
+196 −0

Conversation

hadley
Copy link
Member

@hadley hadley commented Oct 6, 2025

Fixes #1836. Fixes #2235

@claude Claude
Copy link

claude bot commented Oct 6, 2025 •
edited
Loading

Claude finished @hadley's task —— View job

Code Review

  • Review new expect_all_equal() implementation
  • Check test coverage and snapshots
  • Review modifications to expect-match.R
  • Identify potential bugs or issues
  • Provide minimal feedback

Analysis

The PR introduces expect_all_equal() - a function to test that all elements in a vector equal a single expected value. Implementation looks solid:

  • Input validation is comprehensive (R/expect-all.R:5-13)
  • Uses existing expect_waldo_equal_() infrastructure correctly
  • Test coverage is good with edge cases and error scenarios
  • Snapshots show appropriate error messages

The refactoring of show_text() in expect-match.R improves the API by making the labels parameter more generic.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest a new expectation around "Vector with a constant value" all= argument for expect_true()/expect_false()
1 participant
@hadley