Skip to content

More informative output in expect_identical() #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2015
Merged

More informative output in expect_identical() #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51c8b60
use compare() for more informative output in expect_identical()
Nov 10, 2015
58c2a39
NEWS
Nov 10, 2015
c2a3804
update .gitattributes
Nov 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/NEWS merge=union
/NEWS.md merge=union
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
* Added [Catch](https://github.com/philsquared/Catch) for unit testing of C++ code.
See `?use_catch()` for more details. (@kevinushey)

* `expect_identical()` and `is_identical_to()` now use `compare()` for more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I think it's safer to always put new NEWS items at the top, so they're anchored at a fixed position.

detailed output of differences (@krlmlr, #319).

# testthat 0.11.0

* Handle skipped tests in the TAP reporter (#262).
Expand Down
2 changes: 1 addition & 1 deletion R/expectations-equality.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ is_identical_to <- function(expected, label = NULL) {
if (isTRUE(same)) {
diff <- "Objects equal but not identical"
} else {
diff <- paste0(same, collapse = "\n")
diff <- compare(actual, expected)$message
}
}

Expand Down