Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore boolean mental model #106

Closed
hadley opened this issue Aug 8, 2019 · 3 comments
Closed

Explore boolean mental model #106

hadley opened this issue Aug 8, 2019 · 3 comments
Labels
dsl feature

Comments

@hadley
Copy link
Member

@hadley hadley commented Aug 8, 2019

E.g. make ! equivalent to !: I suspect people try it and get confused by the error message. It leads to a slightly misleading mental model of how tidyselect works under the hood, but I think the fact that -"x" already works means that we don't need to worry too much.

And make & and | work. We also need to figure out whether to the vectorised or short-circuiting operators are the most intuitive to most people.

@hadley hadley changed the title Make ! an alias for - Explore boolean mental model Aug 9, 2019
@hadley
Copy link
Member Author

@hadley hadley commented Aug 14, 2019

Worry: it's easy to say "I want columns x and y", but that's actually select(df, x | y)

@lionel-
Copy link
Member

@lionel- lionel- commented Aug 15, 2019

Maybe these operators shouldn't work with bare symbols?

Other cases should be fine, e.g. is.numeric | is.factor, or starts_with("foo") & ends_with("bar").

@hadley
Copy link
Member Author

@hadley hadley commented Aug 15, 2019

Yeah, that makes sense - all of the other options are more obviously predicate functions.

@lionel- lionel- added feature dsl labels Sep 9, 2019
lionel- added a commit to lionel-/tidyselect that referenced this issue Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dsl feature
Projects
None yet
Development

No branches or pull requests

2 participants