Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_tidy_contributing #143

Closed
batpigandme opened this issue Dec 21, 2017 · 0 comments
Closed

use_tidy_contributing #143

batpigandme opened this issue Dec 21, 2017 · 0 comments

Comments

@batpigandme
Copy link
Member

@batpigandme batpigandme commented Dec 21, 2017

Assuming it’s possible that someone would want to use use_tidy_contributing() for a non-tidyverse package (e.g. r-lib), it would make more sense to build the Travis URL in the same way it’s done for use_travis()

url <- file.path("https://travis-ci.org", gh$username, gh$repo)

As opposed to hardcoding it as http://travis-ci.org/tidyverse, name (where name is the package name, and I just skip using the gh package altogether.
But, it would be gh$org in the case of tidyverse and/or r-lib, right?

Alternately, I could use remotes from desc::desc_get_remotes, but, since I'm developing off of a fork, I can't tell whether or not that would actually work 😬!

@hadley hadley closed this in #150 Dec 22, 2017
hadley added a commit that referenced this issue Dec 22, 2017
Fixes #143. Supersedes #144.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant