Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VignetteBuilder DECSRIPTION field split over lines is not recognized #439

Closed
jackwasey opened this issue Aug 17, 2018 · 3 comments
Closed
Labels
bug an unexpected problem or unintended behavior description 📚 docs 💡 documentation, news, vignettes, website, etc

Comments

@jackwasey
Copy link

I have a package DESCRIPTION which, after using desc package to reformat, contains:

VignetteBuilder:
    knitr

In this case, using

usethis:::use_description_field("VignetteBuilder", "knitr")

or, as I originally did:

use_vignette("Medical Twitter strategies used by other authors")

gives the error:

Error: VignetteBuilder has a different value in DESCRIPTION. Use overwrite = TRUE to overwrite.

Furthermore, the error message refers to an argument to usethis:::use_description_field which is not passed through by use_vignette and thus it is not possible to act on this by doing use_vignette("name", overwrite = TRUE)

@hadley hadley added bug an unexpected problem or unintended behavior docs 💡 documentation, news, vignettes, website, etc description 📚 labels Nov 24, 2018
@hadley
Copy link
Member

hadley commented Nov 25, 2018

@gaborcsardi there's no standard desc API for fields that are comma separated values, right? So this will require an issue in desc first.

@gaborcsardi
Copy link
Member

@hadley yeah, but this is relatively simple, and there are not too many comma separated fields. So maybe usethis could just handle this?

@hadley
Copy link
Member

hadley commented Nov 26, 2018

Yeah, I can handle it too.

@hadley hadley closed this as completed in efafb28 Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior description 📚 docs 💡 documentation, news, vignettes, website, etc
Projects
None yet
Development

No branches or pull requests

3 participants