Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecations, bump minor version #259

Merged
merged 1 commit into from
Nov 21, 2020
Merged

remove deprecations, bump minor version #259

merged 1 commit into from
Nov 21, 2020

Conversation

Enchufa2
Copy link
Member

This removes as.units, as_cf, make_unit and parse_unit, which have been deprecated for a long time (since v0.5, 2018-01-07), and consequently bumps version to 0.7-0. I removed all calls and mentions to them in docs, demos and tests.

I think it's time to remove ud_units too, which is unneeded and soft-deprecated since v0.5 as well (and it only generates confusion, e.g. #211), but I wanted to ask you @edzer first.

@Enchufa2 Enchufa2 requested a review from edzer November 21, 2020 15:27
@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #259 (14b3549) into master (541a96c) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   93.97%   94.05%   +0.07%     
==========================================
  Files          19       18       -1     
  Lines         897      891       -6     
==========================================
- Hits          843      838       -5     
+ Misses         54       53       -1     
Impacted Files Coverage Δ
R/misc.R 100.00% <ø> (ø)
R/conversion.R 88.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541a96c...14b3549. Read the comment docs.

@edzer edzer merged commit 141e7b8 into master Nov 21, 2020
@edzer
Copy link
Member

edzer commented Nov 21, 2020

Good idea. What was again the reason to deprecate ud_units, do we no longer use it? I mention it in the vignette, that would need updating too.

@edzer edzer deleted the deprecations branch November 21, 2020 16:27
@Enchufa2
Copy link
Member Author

Prior to v0.5-0, ud_units was internally used by set_units and as_units. NEWS for v0.5-0 said:

ud_units is no longer necessary and is soft-deprecated, and may be removed in a future release.

@edzer
Copy link
Member

edzer commented Nov 21, 2020

OK, let's pull the plug. I'll update that vignette.

edzer added a commit that referenced this pull request Nov 21, 2020
Enchufa2 added a commit that referenced this pull request Nov 21, 2020
@Enchufa2
Copy link
Member Author

Ok, plug pulled in the commit referenced above. I've removed:

  • the private sysdata.rda;
  • all the code associated;
  • the few tests associated;
  • all the examples in docs, demos and the other vignette.

I've converted every appearance of with(ud_units, someunit) to make_units(someunit).

@Enchufa2 Enchufa2 mentioned this pull request Nov 22, 2020
@edzer
Copy link
Member

edzer commented Nov 22, 2020

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants