accelerate printing #957
Closed
accelerate printing #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2019
Closed
Closed
|
I see a lot of differences when I run R CMD check. Why is that? |
|
It's surprising that travis didn't pick it. In fact I was surprised I didn't have to change more than two tests. I have the same output than travis on my computer. I tried on a different computer I have the same error than you. Do you think we should improve defaults or update the expected outputs? |
|
It suggests to me that either formatC gives unpredictable outputs, or outputs with much less significant digits than we expect - both do not sound right. We still need a replacement that gives the same output and is sensitive to |
|
Regarding rounding: iirc one or two years ago there has been a bug report on r-devel that R on windows rounds different than R on Mac/Linux. I checked it and could confirm the problem. As far as I know this was not patched. This might explain, why some (windows) machines bark on certain tests, while other OSes do not. [Edit] This is the report [1]. My findings at that time were: [1] http://r.789695.n4.nabble.com/Rounding-in-print-summaryDefault-td4734921.html |
|
It is surprising that it passed both travis AND appveyor checks because appveyor shows differences (travis also). So two questions: why are build passing? How to get a similar output? (although if even R doesn't achieve it, we might find it difficult.) |
|
Tests as .R files in the |
|
I'll close this PR since 90821d8 uses Please reopen if you feel there's something we should finish in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
formatCto accelerate printing of geometries. It also has the same behavior than thedigitsoption in base R (lwgeomonly offers control for the number of decimals).@harryprince, @JanMarvin, @adrfantini, if you could test your use case and report, that would be super useful. (I did test with the #703 data.)
close #800, #947, #703, #747, #703
related #713