Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes your package compatible with the next version of dplyr:
The join functions in dplyr (like
left_join()
) now return a warning by default when a row inx
matches multiple rows iny
. While this is typical SQL behavior, it is often unexpected during data analysis (many people don't even know it is possible), so we've decided to make this a warning. In dplyr 1.1.0, you silence this warning withmultiple = "all"
. In the meantime, to be compatible with both dev and CRAN dplyr we need to work around broken tests of yours that were expecting no warnings. I've done that by suppressing the warnings in the join calls that caused errors. You can switch to explicitly settingmultiple = "all"
instead after the dplyr 1.1.0 release, but this should work for both dev and CRAN dplyr in the meantime.We plan to submit dplyr 1.1.0 on January 27th.
This should be compatible with both dev and CRAN dplyr. It would help us out if you could go ahead and send a patch version of your package to CRAN ahead of time! Thanks!