Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False error reported? #415

Closed
1 task done
tomhajjar opened this issue Dec 28, 2023 · 7 comments
Closed
1 task done

False error reported? #415

tomhajjar opened this issue Dec 28, 2023 · 7 comments
Labels

Comments

@tomhajjar
Copy link

tomhajjar commented Dec 28, 2023

An error was reported during simulation but the Log only shows the term "error_amp_out" which isn't an actual error.

Attached is the project and a ngspice test folder using DuSpice including the log file.

TODO

  • Use something like Regexp pattern for error recognition in the Ngspice log

2023-12-28_131642

LM317_LM337_prj.zip

LM337_ripple.zip

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 29, 2023

Yes, Qucs-S shows "Simulation error" message if the log contains the string "error". It is not obvious how to fix it, because Ngspice has no unified format for the error message. Maybe some RegExp would help.

@ra3xdh ra3xdh added the ngspice label Dec 29, 2023
@dwarning
Copy link

I am not sure and don't know the model but I think error_amp_out is a node name - the output of the regulator error amplifier. So don't worry - no ngspice problem.

@tomhajjar
Copy link
Author

tomhajjar commented Dec 29, 2023

Yes the "error" is false.

Unfortunately after I GREP'd the ngspice source I found dozens of different "Error" text strings. Most contain "Error:" but a lot don't. It would be hard to parse so many variations and the number only increases every release.

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 29, 2023

@dwarning , The solution may be to flag "Simulation error" in the Qucs-S only if the log contains "Error" or "ERROR" strings. The "error" in lower case most probably means the node name.

@tomhajjar
Copy link
Author

I searched the ngspice forum and GREP'd the source and found the following error strings. There are many more...

Error:
Error(
Error (
Error on line XXX:
Error on line:
Syntax error:
Expression err:
Numparam expansion errors:
Error in netlist line number...

@ra3xdh
Copy link
Owner

ra3xdh commented Jan 6, 2024

I have added TODO list for this issue.

@ra3xdh
Copy link
Owner

ra3xdh commented Jan 7, 2024

I have implemented pattern recognition for error messages. The node name error should not raise error flag anymore. Closing this as completed.

@ra3xdh ra3xdh closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants