Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed git hash. #810

Merged
merged 1 commit into from
Jul 6, 2024
Merged

fixed git hash. #810

merged 1 commit into from
Jul 6, 2024

Conversation

dsm
Copy link
Collaborator

@dsm dsm commented Jul 5, 2024

Hi, this PR fix this.

I tried mac built-in git 2.39.5 and it gives no warning and no hash,
but recent version installed via homebrew gives warning
also windows and linux do the same thing.

  • git gives a warning -> fatal: '1u': not an integer

git gives a warning -> fatal: '1u': not an integer
@ra3xdh
Copy link
Owner

ra3xdh commented Jul 6, 2024

Thanks! Merged. Another problem is that the latest Windows continuous build has the share subdirectory missing. It contains only bin subdirectory inside the archive.

@ra3xdh ra3xdh merged commit 4e9188c into ra3xdh:current Jul 6, 2024
6 checks passed
@dsm
Copy link
Collaborator Author

dsm commented Jul 6, 2024

I'll fix this thanks.

@dsm
Copy link
Collaborator Author

dsm commented Jul 6, 2024

Same naming typo in zip the files not ./re it sould be ./share

@ra3xdh ra3xdh added the CI label Jul 7, 2024
@dsm dsm deleted the fix_git_hash_cmake branch July 8, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants