Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fillUp and fillUpChunks to be make more generic #15

Closed
piyush-kurur opened this issue Dec 6, 2012 · 1 comment
Closed

fillUp and fillUpChunks to be make more generic #15

piyush-kurur opened this issue Dec 6, 2012 · 1 comment

Comments

@piyush-kurur
Copy link
Member

Instead of them taking BYTES Int as argument, make them take any length type that are crypto-coerceble to BYTES Int. This can avoind some cryptoCoerce calls by the callee
@piyush-kurur
Copy link
Member Author

Actually it is not fillUp and fillUpChunks that need to change but unsafeNCopyToCryptoPtr. Infact changing the types could actually make fillUp and fillUpChunks unsafe, as they need to return the remaining characters in bytes.

piyush-kurur added a commit that referenced this issue Dec 6, 2012
@piyush-kurur
generalised unsafeNCopyToCryptoPtr to accept arbitrary typesafe lengths
b571e49 
fixes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@piyush-kurur