Global control of client-movement #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When would you be changing this value during run time? If at compile time
just create a global in your code and pass that to the parameter. I have
cases in code that some windows are client and some are server controlled
in the same app.
…On Tue, May 10, 2022, 9:10 AM Mariano Montone ***@***.***> wrote:
Hi.
I would like to control global value of client-movement using a global
variable as default that can be changed to switch between client/server
movement when it has not been explicitly specified.
Do you agree?
------------------------------
You can view, comment on, or merge this pull request online at:
#127
Commit Summary
- f122007
<f122007>
Global control of client-movement
File Changes
(1 file <https://github.com/rabbibotton/clog/pull/127/files>)
- *M* source/clog-gui.lisp
<https://github.com/rabbibotton/clog/pull/127/files#diff-580421e5bbcbbfb40934d5fd2f6c661770cf973815925de1a648628eab0d3933>
(16)
Patch Links:
- https://github.com/rabbibotton/clog/pull/127.patch
- https://github.com/rabbibotton/clog/pull/127.diff
—
Reply to this email directly, view it on GitHub
<#127>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYUEFPUTC7XWNWUIP4DB4LVJJN4XANCNFSM5VRRGLYQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
El 10/5/22 a las 11:19, David Botton escribió:
When would you be changing this value during run time? If at compile time
just create a global in your code and pass that to the parameter.
Yes, but I think it could be convenient to just be able to turn on/off
globally. For example, when going through the clog demos, I can turn on
client-movement and see how it behaves without having to modifiy all the
code and pass the parameter.
I have
cases in code that some windows are client and some are server controlled
in the same app.
You would still have control over that passing parameter. This is just a
global default.
…
On Tue, May 10, 2022, 9:10 AM Mariano Montone ***@***.***>
wrote:
> Hi.
>
> I would like to control global value of client-movement using a global
> variable as default that can be changed to switch between client/server
> movement when it has not been explicitly specified.
>
> Do you agree?
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #127
> Commit Summary
>
> - f122007
>
<f122007>
> Global control of client-movement
>
> File Changes
>
> (1 file <https://github.com/rabbibotton/clog/pull/127/files>)
>
> - *M* source/clog-gui.lisp
>
<https://github.com/rabbibotton/clog/pull/127/files#diff-580421e5bbcbbfb40934d5fd2f6c661770cf973815925de1a648628eab0d3933>
> (16)
>
> Patch Links:
>
> - https://github.com/rabbibotton/clog/pull/127.patch
> - https://github.com/rabbibotton/clog/pull/127.diff
>
> —
> Reply to this email directly, view it on GitHub
> <#127>, or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ACYUEFPUTC7XWNWUIP4DB4LVJJN4XANCNFSM5VRRGLYQ>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#127 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADKPDV6ZZ6QTGKOY6WC2FDVJJV73ANCNFSM5VRRGLYQ>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Can you give me the practical case so I can think it over?
On Tue, May 10, 2022, 10:26 AM Mariano Montone ***@***.***>
wrote:
… El 10/5/22 a las 11:19, David Botton escribió:
> When would you be changing this value during run time? If at compile time
> just create a global in your code and pass that to the parameter.
Yes, but I think it could be convenient to just be able to turn on/off
globally. For example, when going through the clog demos, I can turn on
client-movement and see how it behaves without having to modifiy all the
code and pass the parameter.
> I have
> cases in code that some windows are client and some are server controlled
> in the same app.
You would still have control over that passing parameter. This is just a
global default.
>
> On Tue, May 10, 2022, 9:10 AM Mariano Montone ***@***.***>
> wrote:
>
> > Hi.
> >
> > I would like to control global value of client-movement using a global
> > variable as default that can be changed to switch between client/server
> > movement when it has not been explicitly specified.
> >
> > Do you agree?
> > ------------------------------
> > You can view, comment on, or merge this pull request online at:
> >
> > #127
> > Commit Summary
> >
> > - f122007
> >
> <
f122007
>
> > Global control of client-movement
> >
> > File Changes
> >
> > (1 file <https://github.com/rabbibotton/clog/pull/127/files>)
> >
> > - *M* source/clog-gui.lisp
> >
> <
https://github.com/rabbibotton/clog/pull/127/files#diff-580421e5bbcbbfb40934d5fd2f6c661770cf973815925de1a648628eab0d3933
>
> > (16)
> >
> > Patch Links:
> >
> > - https://github.com/rabbibotton/clog/pull/127.patch
> > - https://github.com/rabbibotton/clog/pull/127.diff
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <#127>, or unsubscribe
> >
> <
https://github.com/notifications/unsubscribe-auth/ACYUEFPUTC7XWNWUIP4DB4LVJJN4XANCNFSM5VRRGLYQ
>
> > .
> > You are receiving this because you are subscribed to this
thread.Message
> > ID: ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <#127 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AADKPDV6ZZ6QTGKOY6WC2FDVJJV73ANCNFSM5VRRGLYQ
>.
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#127 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYUEFJFBCPDPDP6OQ4JUBDVJJW27ANCNFSM5VRRGLYQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
El 10/5/22 a las 11:30, David Botton escribió:
Can you give me the practical case so I can think it over?
Let's say I load one of clog-gui demos, and I want to enable/disable
client window movement to observe the difference between server or client.
Not very important perhaps, but I thought it could be convenient.
…
On Tue, May 10, 2022, 10:26 AM Mariano Montone ***@***.***>
wrote:
> El 10/5/22 a las 11:19, David Botton escribió:
> > When would you be changing this value during run time? If at
compile time
> > just create a global in your code and pass that to the parameter.
> Yes, but I think it could be convenient to just be able to turn on/off
> globally. For example, when going through the clog demos, I can turn on
> client-movement and see how it behaves without having to modifiy all the
> code and pass the parameter.
> > I have
> > cases in code that some windows are client and some are server
controlled
> > in the same app.
>
> You would still have control over that passing parameter. This is just a
> global default.
>
>
> >
> > On Tue, May 10, 2022, 9:10 AM Mariano Montone ***@***.***>
> > wrote:
> >
> > > Hi.
> > >
> > > I would like to control global value of client-movement using a
global
> > > variable as default that can be changed to switch between
client/server
> > > movement when it has not been explicitly specified.
> > >
> > > Do you agree?
> > > ------------------------------
> > > You can view, comment on, or merge this pull request online at:
> > >
> > > #127
> > > Commit Summary
> > >
> > > - f122007
> > >
> > <
>
f122007
> >
> > > Global control of client-movement
> > >
> > > File Changes
> > >
> > > (1 file <https://github.com/rabbibotton/clog/pull/127/files>)
> > >
> > > - *M* source/clog-gui.lisp
> > >
> > <
>
https://github.com/rabbibotton/clog/pull/127/files#diff-580421e5bbcbbfb40934d5fd2f6c661770cf973815925de1a648628eab0d3933
> >
> > > (16)
> > >
> > > Patch Links:
> > >
> > > - https://github.com/rabbibotton/clog/pull/127.patch
> > > - https://github.com/rabbibotton/clog/pull/127.diff
> > >
> > > —
> > > Reply to this email directly, view it on GitHub
> > > <#127>, or unsubscribe
> > >
> > <
>
https://github.com/notifications/unsubscribe-auth/ACYUEFPUTC7XWNWUIP4DB4LVJJN4XANCNFSM5VRRGLYQ
> >
> > > .
> > > You are receiving this because you are subscribed to this
> thread.Message
> > > ID: ***@***.***>
> > >
> >
> > —
> > Reply to this email directly, view it on GitHub
> >
<#127 (comment)>,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AADKPDV6ZZ6QTGKOY6WC2FDVJJV73ANCNFSM5VRRGLYQ
> >.
> > You are receiving this because you authored the thread.Message ID:
> > ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <#127 (comment)>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ACYUEFJFBCPDPDP6OQ4JUBDVJJW27ANCNFSM5VRRGLYQ>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#127 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADKPDSZGRDJBG4DO4L5PH3VJJXINANCNFSM5VRRGLYQ>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
A may consider adding a global to one of the tutorials, but I don't think it makes sense to change the framework. The only reason for changing to start with is to moderate network traffic or add responsiveness on slow networks and I think those type of changes should be thought out on a window by window basis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I would like to control global value of client-movement using a global variable as default that can be changed to switch between client/server movement when it has not been explicitly specified.
Do you agree?