Simplify {error, timeout} error type
#256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this return value was '{error,{timeout,RaLeaderId}}'. Leader
information is generally not useful to Khepri API consumers though since
Khepri covers leader redirection. So this change removes the leader ID
from the error type and returns '{error,timeout}' instead.
dumbbell
changed the title
{error,timeout} error type{error, timeout} error type
dumbbell
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
May 16, 2024
dumbbell
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
May 17, 2024
the-mikedavis
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jul 9, 2024
the-mikedavis
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jul 10, 2024
the-mikedavis
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jul 10, 2024
mergify bot
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jul 10, 2024
See rabbitmq/khepri#256. (cherry picked from commit 88c1ad2)
the-mikedavis
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jul 10, 2024
See rabbitmq/khepri#256. (cherry picked from commit 88c1ad2)
the-mikedavis
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Jul 10, 2024
See rabbitmq/khepri#256. (cherry picked from commit 88c1ad2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this return value was '
{error,{timeout,RaLeaderId}}. Leader information is generally not useful to Khepri API consumers though since Khepri covers leader redirection. So this change removes the leader ID from the error type and returns{error,timeout}instead.