This repository was archived by the owner on Nov 17, 2020. It is now read-only.
rabbit_ssl_options: Blacklist TLS 1.3 until Erlang client implementation is finished #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion is finished Erlang 22 will introduce TLS 1.3, but at the time of this commit, only the server side is implemented. If the Erlang client requests TLS 1.3, the server will accept but the client will either hang or crash. So for now, just blacklist TLS 1.3 to avoid any issues, even on the server side, just to be safe. [#165214130]
michaelklishin
approved these changes
Apr 11, 2019
dumbbell
deleted the
blacklist-tls1.3-until-client-implementation-is-finished
branch
|
Yes, I agree. Thank you! I'm waiting for the CI pipeline to test that change and I'll backport it to |
|
Backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erlang 22 will introduce TLS 1.3, but at the time of this commit, only the server side is implemented. If the Erlang client requests TLS 1.3, the server will accept but the client will either hang or crash.
So for now, just blacklist TLS 1.3 to avoid any issues, even on the server side, just to be safe.
This should be backported to
v3.7.xif accepted.[#165214130]