This repository was archived by the owner on Nov 17, 2020. It is now read-only.
epmd-starter improvements #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `noinput` * Use `-s erlang halt` to skip small `eval` overhead * Use `no_dot_erlang` boot file since we do not want user customizations to interfere
dumbbell
approved these changes
Nov 15, 2019
|
The patch looks good to me. Do you think we can get the reporter to try it? Because so far, he was the only one being able to reproduce the problem. |
|
@dumbbell I just asked in this Slack thread: https://rabbitmq.slack.com/archives/C1EDN83PA/p1573732189440700 |
lukebakken
added a commit
that referenced
this pull request
Nov 19, 2019
epmd-starter improvements (cherry picked from commit 7e10c59)
lukebakken
added a commit
that referenced
this pull request
Nov 19, 2019
epmd-starter improvements (cherry picked from commit 7e10c59)
|
Backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noinput-s erlang haltto skip smallevaloverheadno_dot_erlangboot file since we do not want user customizations to interfereFWIW I can't reproduce the rogue-
raissue.